kubernetes-sigs / azurefile-csi-driver

Azure File CSI Driver
Apache License 2.0
153 stars 141 forks source link

fix: incorrect status.creationTime value in snapshot creation with useDataPlaneAPI: “true” #1960

Closed umagnus closed 1 month ago

umagnus commented 1 month ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix: incorrect status.creationTime value in snapshot creation with useDataPlaneAPI: “true” issue: https://github.com/kubernetes-sigs/azurefile-csi-driver/issues/1957 Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer: test result:

$ k describe vs
WARNING: version difference between client (1.30) and server (1.28) exceeds the supported minor version skew of +/-1
Name:         azurefile-volume-snapshot
Namespace:    default
Labels:       <none>
Annotations:  <none>
API Version:  snapshot.storage.k8s.io/v1
Kind:         VolumeSnapshot
Metadata:
  Creation Timestamp:  2024-07-08T07:21:45Z
  Finalizers:
    snapshot.storage.kubernetes.io/volumesnapshot-as-source-protection
    snapshot.storage.kubernetes.io/volumesnapshot-bound-protection
  Generation:        1
  Resource Version:  16426
  UID:               c1ac2cb9-8ad4-4755-8e39-2010b30f676e
Spec:
  Source:
    Persistent Volume Claim Name:  pvc-azurefile
  Volume Snapshot Class Name:      csi-azurefile-vsc
Status:
  Bound Volume Snapshot Content Name:  snapcontent-c1ac2cb9-8ad4-4755-8e39-2010b30f676e
  Creation Time:                       2024-07-08T07:21:46Z
  Ready To Use:                        true
  Restore Size:                        100Gi
Events:
  Type    Reason            Age   From                 Message
  ----    ------            ----  ----                 -------
  Normal  CreatingSnapshot  5s    snapshot-controller  Waiting for a snapshot default/azurefile-volume-snapshot to be created by the CSI driver.
  Normal  SnapshotCreated   5s    snapshot-controller  Snapshot default/azurefile-volume-snapshot was successfully created by the CSI driver.
  Normal  SnapshotReady     5s    snapshot-controller  Snapshot default/azurefile-volume-snapshot is ready to use.

image

Release note:

none
k8s-ci-robot commented 1 month ago

Hi @umagnus. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: umagnus Once this PR has been reviewed and has the lgtm label, please assign andyzhangx for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/azurefile-csi-driver/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andyzhangx commented 1 month ago

/ok-to-test

andyzhangx commented 1 month ago

/retest

andyzhangx commented 1 month ago

/retest

andyzhangx commented 1 month ago

/retest

k8s-ci-robot commented 1 month ago

@umagnus: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azurefile-csi-driver-e2e-migration-windows a29b7b29de00b23a343c8eea90d7c9696cf7ac5f link true /test pull-azurefile-csi-driver-e2e-migration-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
andyzhangx commented 1 month ago

/cherrypick release-1.30

andyzhangx commented 1 month ago

/cherrypick release-1.29

andyzhangx commented 1 month ago

/cherrypick release-1.28

k8s-infra-cherrypick-robot commented 1 month ago

@andyzhangx: new pull request created: #1965

In response to [this](https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/1960#issuecomment-2213959624): >/cherrypick release-1.30 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 1 month ago

@andyzhangx: new pull request created: #1966

In response to [this](https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/1960#issuecomment-2213959799): >/cherrypick release-1.29 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 1 month ago

@andyzhangx: new pull request created: #1967

In response to [this](https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/1960#issuecomment-2213959929): >/cherrypick release-1.28 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.