kubernetes-sigs / azurefile-csi-driver

Azure File CSI Driver
Apache License 2.0
153 stars 141 forks source link

feat: add support for confidential pods #1971

Open arc9693 opened 1 month ago

arc9693 commented 1 month ago

What type of PR is this?

What this PR does / why we need it: Kata-cc is a lightweight VM based runtime for containers. As of now, the azurefile-csi-driver’s persistent storage does not work for kata-cc or confidential pods. The file sharing between host and guest is disabled and therefore the SMB mount on host node does not propagate as expected for the pod. The proposed changes enable the SMB mount inside the guest VM that wraps the confidential pod.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none
linux-foundation-easycla[bot] commented 1 month ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 1 month ago

Welcome @arc9693!

It looks like this is your first PR to kubernetes-sigs/azurefile-csi-driver πŸŽ‰. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/azurefile-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 month ago

Hi @arc9693. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arc9693 Once this PR has been reviewed and has the lgtm label, please assign andyzhangx for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/azurefile-csi-driver/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andyzhangx commented 1 month ago

@arc9693 thanks for the PR, can you sign the cla license first? thx

andyzhangx commented 3 weeks ago

/test pull-azurefile-csi-driver-verify

andyzhangx commented 2 weeks ago

/retest

k8s-ci-robot commented 2 weeks ago

@arc9693: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azurefile-csi-driver-sanity b82313efd9976ac588fa9d876b46a37ebe5bd263 link true /test pull-azurefile-csi-driver-sanity
pull-azurefile-csi-driver-external-e2e-smb b82313efd9976ac588fa9d876b46a37ebe5bd263 link true /test pull-azurefile-csi-driver-external-e2e-smb
pull-azurefile-csi-driver-external-e2e-nfs b82313efd9976ac588fa9d876b46a37ebe5bd263 link true /test pull-azurefile-csi-driver-external-e2e-nfs
pull-azurefile-csi-driver-e2e-capz b82313efd9976ac588fa9d876b46a37ebe5bd263 link true /test pull-azurefile-csi-driver-e2e-capz
pull-azurefile-csi-driver-e2e-migration b82313efd9976ac588fa9d876b46a37ebe5bd263 link true /test pull-azurefile-csi-driver-e2e-migration
pull-azurefile-csi-driver-e2e-migration-windows b82313efd9976ac588fa9d876b46a37ebe5bd263 link true /test pull-azurefile-csi-driver-e2e-migration-windows
pull-azurefile-csi-driver-e2e-capz-windows-2019-hostprocess b82313efd9976ac588fa9d876b46a37ebe5bd263 link true /test pull-azurefile-csi-driver-e2e-capz-windows-2019-hostprocess
pull-azurefile-csi-driver-e2e-capz-windows-2019 b82313efd9976ac588fa9d876b46a37ebe5bd263 link true /test pull-azurefile-csi-driver-e2e-capz-windows-2019
pull-azurefile-csi-driver-e2e-capz-windows-2022-hostprocess b82313efd9976ac588fa9d876b46a37ebe5bd263 link true /test pull-azurefile-csi-driver-e2e-capz-windows-2022-hostprocess

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 1 week ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.