kubernetes-sigs / azurefile-csi-driver

Azure File CSI Driver
Apache License 2.0
158 stars 143 forks source link

[release-1.29] revert: creating private endpoints for multiple subnets #2088

Closed andyzhangx closed 2 months ago

andyzhangx commented 2 months ago

What type of PR is this? /kind bug

What this PR does / why we need it: revert: creating private endpoints for multiple subnets revert of https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/2065

https://learn.microsoft.com/en-us/azure/private-link/private-link-faq#can-we-link-multiple-private-dns-zones-with-the-same-name--

Do I require a dedicated subnet for Private Endpoints? No. You don't require a dedicated subnet for Private Endpoints. You can choose a Private Endpoint IP from any subnet from the VNet where your service is deployed.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

revert: creating private endpoints for multiple subnets
k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/azurefile-csi-driver/blob/release-1.29/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andyzhangx commented 2 months ago

/retest