search

kubernetes-sigs / azurefile-csi-driver

Azure File CSI Driver
Apache License 2.0
158 stars 143 forks source link

fix: reduce get file share throttling when CreateSnapshot #2153

Closed andyzhangx closed 3 weeks ago

andyzhangx commented 1 month ago

What type of PR is this? /kind bug

What this PR does / why we need it: fix: reduce get file share throttling when CreateSnapshot, this PR uses the filter as fileShareName to only get snapshots under the specified file share

Which issue(s) this PR fixes:

Fixes #2152

Requirements:

Special notes for your reviewer:

Release note:

fix: reduce get file share throttling when CreateSnapshot
k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/azurefile-csi-driver/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andyzhangx commented 1 month ago

/retest

andyzhangx commented 3 weeks ago

/retest

k8s-ci-robot commented 3 weeks ago

@andyzhangx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azurefile-csi-driver-e2e-capz-windows-2019 ef7dce7fa17b9ac7649a7f20e76cd5e488618e9b link true /test pull-azurefile-csi-driver-e2e-capz-windows-2019

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
andyzhangx commented 3 weeks ago

/cherrypick release-1.31

andyzhangx commented 3 weeks ago

/cherrypick release-1.30

andyzhangx commented 3 weeks ago

/cherrypick release-1.29

k8s-infra-cherrypick-robot commented 3 weeks ago

@andyzhangx: new pull request created: #2161

In response to [this](https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/2153#issuecomment-2454697876): >/cherrypick release-1.31 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 3 weeks ago

@andyzhangx: new pull request created: #2162

In response to [this](https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/2153#issuecomment-2454698267): >/cherrypick release-1.30 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 3 weeks ago

@andyzhangx: #2153 failed to apply on top of branch "release-1.29":

Applying: fix: reduce get file share throttling when CreateSnapshot
Using index info to reconstruct a base tree...
M   pkg/azurefile/controllerserver.go
M   test/sanity/run-test.sh
Falling back to patching base and 3-way merge...
Auto-merging test/sanity/run-test.sh
CONFLICT (content): Merge conflict in test/sanity/run-test.sh
Auto-merging pkg/azurefile/controllerserver.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix: reduce get file share throttling when CreateSnapshot
In response to [this](https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/2153#issuecomment-2454698759): >/cherrypick release-1.29 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.