kubernetes-sigs / azurelustre-csi-driver

Apache License 2.0
12 stars 22 forks source link

Skip ReadWriteOncePod e2e tests #135

Closed dabradley closed 1 year ago

dabradley commented 1 year ago

The Kubernetes clusters we run our e2e tests against do not have the ReadWriteOncePod feature enabled by default. The test suite has changed to run these tests against the alpha / beta supported versions of this feature. This commit continues to skip these tests until we are actively testing against Kubernets 1.27+ where this feature is enabled by default.

What type of PR is this? /kind test

What this PR does / why we need it: The Kubernetes clusters we run our e2e tests against do not have the ReadWriteOncePod feature enabled by default. The test suite has changed to run these tests against the alpha / beta supported versions of this feature. This commit continues to skip these tests until we are actively testing against Kubernets 1.27+ where this feature is enabled by default.

Which issue(s) this PR fixes:

Fixes #134

Requirements:

Special notes for your reviewer:

Release note:

none
k8s-ci-robot commented 1 year ago

@dabradley: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes-sigs/azurelustre-csi-driver/pull/135): >The Kubernetes clusters we run our e2e tests against do not have the ReadWriteOncePod feature enabled by default. The test suite has changed to run these tests against the alpha / beta supported versions of this feature. This commit continues to skip these tests until we are ectively testing against Kubernets 1.27+ where this feature is enaled by default. > > > >**What type of PR is this?** >/kind test > > > >**What this PR does / why we need it**: >The Kubernetes clusters we run our e2e tests against do not have the ReadWriteOncePod feature enabled by default. The test suite has changed to run these tests against the alpha / beta supported versions of this feature. This commit continues to skip these tests until we are ectively testing against Kubernets 1.27+ where this feature is enaled by default. > >**Which issue(s) this PR fixes**: > >Fixes #134 > >**Requirements**: >- [ ] uses [conventional commit messages](https://www.conventionalcommits.org/) > >- [ ] includes documentation >- [ ] adds unit tests >- [ ] tested upgrade from previous version > >**Special notes for your reviewer**: > > >**Release note**: >``` >none >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
joe-atzinger commented 1 year ago

/lgtm

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dabradley, joe-atzinger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/azurelustre-csi-driver/blob/main/OWNERS)~~ [joe-atzinger] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment