kubernetes-sigs / azurelustre-csi-driver

Apache License 2.0
12 stars 22 forks source link

Remove retain-sub-dir option #159

Closed dabradley closed 8 months ago

dabradley commented 8 months ago

The retain-sub-dir feature is intended to allow the user to have their subdirectory data automatically cleaned up when a pod unmounts from the Lustre filesystem. However, based on test, in its current form it allows the user to easily get themselves into a bad state or to lose data. For this release, we will maintain the subdirectory creation and mounting logic, but will wait on any customer feedback before re-enabling this functionality based on expected use cases.

What type of PR is this? /kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none
k8s-ci-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dabradley, t-mialve

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/azurelustre-csi-driver/blob/main/OWNERS)~~ [dabradley] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment