kubernetes-sigs / blixt

Layer 4 Kubernetes load-balancer
Apache License 2.0
353 stars 51 forks source link

Docker build CI needs an update post kubernetes-sigs migration #106

Open shaneutt opened 1 year ago

shaneutt commented 1 year ago

Now that we're migrated from https://github.com/kong/blixt to https://github.com/kubernetes-sigs/blixt, some updates need to be made to our container image builds so that we can build and push our images in CI.

shaneutt commented 1 year ago

https://github.com/kubernetes-sigs/blixt/commit/4e6ec82602b93c2a2efb4bcb0ae8e4a199d7e97d simply disabled the push (but runs the build and everything up to it) as a stop-gap until we move our builds to prow.

ameukam commented 9 months ago

cc @ameukam

ameukam commented 9 months ago

GHCR is currently not advised for use since we don't have clarity how repositories exposure. SIG k8s Infra always recommend to use GCP GCR/AR repos for all the subprojects. We have 2 options:

shaneutt commented 9 months ago

Personally I think using an existing one for now is fine, especially if that's easier / more straightforward.

ameukam commented 9 months ago

Personally I think using an existing one for now is fine, especially if that's easier / more straightforward.

With k8s-infra hat on, the first option is preferable with isolation of resource at the project and minimize any security issue. I'll try to setup it if we go with this approach.

shaneutt commented 9 months ago

I'm in favor. @aryan9600, @astoycos, @mlavacca ?

aryan9600 commented 9 months ago

sounds good to me!

shaneutt commented 8 months ago

@ameukam if you're wanting to move forward with that plan, that'll be good 👍