search

kubernetes-sigs / blixt

Layer 4 Kubernetes load-balancer
Apache License 2.0
354 stars 51 forks source link

Bump gateway-api to v1.1.0 #277

Closed cnvergence closed 2 months ago

cnvergence commented 2 months ago

As mentioned in https://github.com/kubernetes-sigs/blixt/issues/81, we should bump the gw-api version to the latest

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cnvergence Once this PR has been reviewed and has the lgtm label, please assign aryan9600 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/blixt/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 2 months ago

Welcome @cnvergence!

It looks like this is your first PR to kubernetes-sigs/blixt 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/blixt has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

shaneutt commented 2 months ago

Hey @cnvergence! We appreciate you jumping on this. For some reason when we talked about this in #81 I had it in my head that we were talking about updating the Gateway API version in the Rust code, not the Golang control plane. We are in the midst of replacing the Golang code, so actually if this is not being as straightforward as it should be, maybe we could just drop it for now? I'm sorry for the crossed wires, this has actually got me thinking that maybe now is the time to just remove the old Golang control-plane to reduce confusion going forward :thinking:

shaneutt commented 2 months ago

Spoke with @cnvergence in Slack (thanks for reaching out!) we're going to close this for now given the above context. Next steps to follow up are to finish the control-plane rewrite, and then we should be able to get back to updates and conformance tests for Gateway API :rocket: