search

kubernetes-sigs / blixt

Layer 4 Kubernetes load-balancer
Apache License 2.0
355 stars 51 forks source link

Fix: detect when hardware platform is aarch64 #281

Closed Gladdstone closed 2 months ago

Gladdstone commented 2 months ago

Currently the makefile fails to select the correct build platform for arm devices that return aarch64 as the result for uname -m.

k8s-ci-robot commented 2 months ago

Welcome @Gladdstone!

It looks like this is your first PR to kubernetes-sigs/blixt 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/blixt has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

shaneutt commented 2 months ago

Nice, thank you!

/approve /lgtm

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gladdstone, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/blixt/blob/main/OWNERS)~~ [shaneutt] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
shaneutt commented 2 months ago

/ok-to-test