search

kubernetes-sigs / blob-csi-driver

Azure Blob Storage CSI driver
Apache License 2.0
120 stars 80 forks source link

fix: strip service account token #1309

Closed cvvz closed 5 months ago

cvvz commented 5 months ago

What type of PR is this? /kind cleanup

What this PR does / why we need it: strip service account token to avoid security risk.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: strip service account token
k8s-ci-robot commented 5 months ago

@cvvz: The label(s) kind/fix cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes-sigs/blob-csi-driver/pull/1309): > > >**What type of PR is this?** >/kind fix > > >**What this PR does / why we need it**: >strip service account token to avoid security risk. > >**Which issue(s) this PR fixes**: > >Fixes # > >**Requirements**: >- [ ] uses [conventional commit messages](https://www.conventionalcommits.org/) > >- [ ] includes documentation >- [ ] adds unit tests >- [ ] tested upgrade from previous version > >**Special notes for your reviewer**: > > >**Release note**: >``` >fix: strip service account token >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cvvz commented 5 months ago

/retest

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/blob-csi-driver/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andyzhangx commented 5 months ago

/cherrypick release-1.24

andyzhangx commented 5 months ago

/cherrypick release-1.23

k8s-infra-cherrypick-robot commented 5 months ago

@andyzhangx: new pull request created: #1310

In response to [this](https://github.com/kubernetes-sigs/blob-csi-driver/pull/1309#issuecomment-2020202835): >/cherrypick release-1.24 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 5 months ago

@andyzhangx: new pull request created: #1311

In response to [this](https://github.com/kubernetes-sigs/blob-csi-driver/pull/1309#issuecomment-2020202947): >/cherrypick release-1.23 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.