search

kubernetes-sigs / blob-csi-driver

Azure Blob Storage CSI driver
Apache License 2.0
123 stars 81 forks source link

fix: workload identity did not work #1318

Closed cvvz closed 6 months ago

cvvz commented 6 months ago

What type of PR is this? /kind bug

What this PR does / why we need it: The same fix as https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2233

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer: https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2233

Release note:

fix: workload identity did not work
k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/blob-csi-driver/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andyzhangx commented 6 months ago

/cherrypick release-1.24

andyzhangx commented 6 months ago

/cherrypick release-1.23

k8s-infra-cherrypick-robot commented 6 months ago

@andyzhangx: #1318 failed to apply on top of branch "release-1.23":

Applying: fix: workload identity did not work
Using index info to reconstruct a base tree...
M   pkg/blob/azure.go
M   pkg/blob/azure_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/blob/azure_test.go
CONFLICT (content): Merge conflict in pkg/blob/azure_test.go
Auto-merging pkg/blob/azure.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: workload identity did not work
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubernetes-sigs/blob-csi-driver/pull/1318#issuecomment-2024639847): >/cherrypick release-1.23 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 6 months ago

@andyzhangx: new pull request created: #1319

In response to [this](https://github.com/kubernetes-sigs/blob-csi-driver/pull/1318#issuecomment-2024639745): >/cherrypick release-1.24 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
andyzhangx commented 6 months ago

@cvvz can you cherrypick this fix into release-1.23?