search

kubernetes-sigs / blob-csi-driver

Azure Blob Storage CSI driver
Apache License 2.0
118 stars 77 forks source link

feat: support setting kubelet path for blobfuse-proxy endpoint #1325

Closed cvvz closed 3 months ago

cvvz commented 3 months ago

What type of PR is this? /kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1236

Requirements:

Special notes for your reviewer:

Release note:

feat: support setting kubelet path for blobfuse-proxy endpoint
k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/blob-csi-driver/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andyzhangx commented 3 months ago

/cherrypick release-1.24

k8s-infra-cherrypick-robot commented 3 months ago

@andyzhangx: #1325 failed to apply on top of branch "release-1.24":

Applying: fix: support setting kubelet path for blobfuse-proxy endpoint
Applying: fix
warning: Cannot merge binary files: charts/latest/blob-csi-driver-v0.0.0.tgz (HEAD vs. fix)
Using index info to reconstruct a base tree...
M   charts/latest/blob-csi-driver-v0.0.0.tgz
Falling back to patching base and 3-way merge...
Auto-merging charts/latest/blob-csi-driver-v0.0.0.tgz
CONFLICT (content): Merge conflict in charts/latest/blob-csi-driver-v0.0.0.tgz
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 fix
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubernetes-sigs/blob-csi-driver/pull/1325#issuecomment-2042415678): >/cherrypick release-1.24 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
andyzhangx commented 3 months ago

@cvvz can you cherrypick to release-1.24? thanks.