kubernetes-sigs / blob-csi-driver

Azure Blob Storage CSI driver
Apache License 2.0
117 stars 75 forks source link

fix: support storeAccountKey as false in cross subscription scenario #1381

Closed andyzhangx closed 2 months ago

andyzhangx commented 2 months ago

What type of PR is this? /kind bug

What this PR does / why we need it: fix: support storeAccountKey as false in cross subscription scenario

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: support storeAccountKey as true in cross subscription scenario
k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/blob-csi-driver/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andyzhangx commented 2 months ago

/retest

andyzhangx commented 2 months ago

/cherrypick release-1.24

andyzhangx commented 2 months ago

/cherrypick release-1.23

andyzhangx commented 2 months ago

/cherrypick release-1.22

k8s-infra-cherrypick-robot commented 2 months ago

@andyzhangx: #1381 failed to apply on top of branch "release-1.22":

Applying: fix: support storeAccountKey as true in cross subscription scenario
Using index info to reconstruct a base tree...
M   docs/driver-parameters.md
M   pkg/blob/controllerserver.go
M   pkg/blob/controllerserver_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/blob/controllerserver_test.go
CONFLICT (content): Merge conflict in pkg/blob/controllerserver_test.go
Auto-merging pkg/blob/controllerserver.go
Auto-merging docs/driver-parameters.md
CONFLICT (content): Merge conflict in docs/driver-parameters.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: support storeAccountKey as true in cross subscription scenario
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubernetes-sigs/blob-csi-driver/pull/1381#issuecomment-2099786727): >/cherrypick release-1.22 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 2 months ago

@andyzhangx: new pull request created: #1382

In response to [this](https://github.com/kubernetes-sigs/blob-csi-driver/pull/1381#issuecomment-2099786666): >/cherrypick release-1.23 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 2 months ago

@andyzhangx: new pull request created: #1383

In response to [this](https://github.com/kubernetes-sigs/blob-csi-driver/pull/1381#issuecomment-2099786572): >/cherrypick release-1.24 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.