kubernetes-sigs / blob-csi-driver

Azure Blob Storage CSI driver
Apache License 2.0
123 stars 83 forks source link

chore: enable blobfuse-proxy by default in kubectl install #1630

Closed andyzhangx closed 1 month ago

andyzhangx commented 1 month ago

What type of PR is this? /kind cleanup

What this PR does / why we need it: chore: enable blobfuse-proxy by default in kubectl install

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none
k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/blob-csi-driver/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andyzhangx commented 1 month ago

/retest

andyzhangx commented 1 month ago

/retest

andyzhangx commented 1 month ago

/retest

andyzhangx commented 1 month ago

/cherrypick release-1.24

andyzhangx commented 1 month ago

/cherrypick release-1.23

andyzhangx commented 1 month ago

/cherrypick release-1.22

k8s-infra-cherrypick-robot commented 1 month ago

@andyzhangx: new pull request created: #1631

In response to [this](https://github.com/kubernetes-sigs/blob-csi-driver/pull/1630#issuecomment-2408526168): >/cherrypick release-1.23 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 1 month ago

@andyzhangx: new pull request created: #1632

In response to [this](https://github.com/kubernetes-sigs/blob-csi-driver/pull/1630#issuecomment-2408526133): >/cherrypick release-1.24 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 1 month ago

@andyzhangx: #1630 failed to apply on top of branch "release-1.22":

Applying: chore: enable blobfuse-proxy by default in kubectl install
Applying: doc: support example pod running on arm64 node
Using index info to reconstruct a base tree...
A   deploy/example/cloning/nginx-pod-restored-cloning.yaml
M   deploy/example/nginx-blobfuse-inline-volume.yaml
M   deploy/example/nginx-pod-blob.yaml
M   deploy/example/statefulset-nfs.yaml
M   deploy/example/statefulset.yaml
Falling back to patching base and 3-way merge...
Auto-merging deploy/example/statefulset.yaml
Auto-merging deploy/example/statefulset-nfs.yaml
Auto-merging deploy/example/nginx-pod-blob.yaml
Auto-merging deploy/example/nginx-blobfuse-inline-volume.yaml
CONFLICT (modify/delete): deploy/example/cloning/nginx-pod-restored-cloning.yaml deleted in HEAD and modified in doc: support example pod running on arm64 node. Version doc: support example pod running on arm64 node of deploy/example/cloning/nginx-pod-restored-cloning.yaml left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 doc: support example pod running on arm64 node
In response to [this](https://github.com/kubernetes-sigs/blob-csi-driver/pull/1630#issuecomment-2408526198): >/cherrypick release-1.22 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.