kubernetes-sigs / blob-csi-driver

Azure Blob Storage CSI driver
Apache License 2.0
123 stars 83 forks source link

fix: don't install blobfuse v1 by default since it's deprecated #1679

Closed andyzhangx closed 2 weeks ago

andyzhangx commented 2 weeks ago

What type of PR is this? /kind bug

What this PR does / why we need it: fix: don't install blobfuse v1 by default since it's deprecated

this PR also fixes the k8s package install issue due to key mismatch error:

``` root@capz-743k9w-control-plane-xgdsr:/home/capi/blob-csi-driver# k logs -n kube-system csi-blob-node-sggdn -c install-blobfuse-proxy + INSTALL_BLOBFUSE_PROXY=true + DISABLE_UPDATEDB=true + SET_MAX_OPEN_FILE_NUM=true + SET_READ_AHEAD_SIZE=true + READ_AHEAD_KB=15380 + KUBELET_PATH=/var/lib/kubelet + [ /var/lib/kubelet != /var/lib/kubelet ] + HOST_CMD=nsenter --mount=/proc/1/ns/mnt + nsenter --mount=/proc/1/ns/mnt cat /etc/os-release + cut -d= -f2 + tr -d " + grep ^ID= + DISTRIBUTION=ubuntu + nsenter --mount=/proc/1/ns/mnt uname -m + ARCH=x86_64 + echo Linux distribution: ubuntu, Arch: x86_64 Linux distribution: ubuntu, Arch: x86_64 + . ./blobfuse-proxy/install-proxy.sh + set -xe + [ ubuntu != ubuntu ] + [ true = true ] start to install blobfuse/blobfuse2.... + echo start to install blobfuse/blobfuse2.... + nsenter --mount=/proc/1/ns/mnt lsb_release -rs + release=22.04 + echo Ubuntu release: 22.04 Ubuntu release: 22.04 + expr 22.04 < 22.04 + [ 0 -eq 1 ] + cp /blobfuse-proxy/packages-microsoft-prod-22.04.deb /host/etc/packages-microsoft-prod.deb + yes + nsenter --mount=/proc/1/ns/mnt dpkg -i /etc/packages-microsoft-prod.deb (Reading database ... 104350 files and directories currently installed.) Preparing to unpack .../packages-microsoft-prod.deb ... Unpacking packages-microsoft-prod (1.0-ubuntu22.04.1) over (1.0-ubuntu22.04.1) ... Setting up packages-microsoft-prod (1.0-ubuntu22.04.1) ... + nsenter --mount=/proc/1/ns/mnt apt update WARNING: apt does not have a stable CLI interface. Use with caution in scripts. Hit:1 http://azure.archive.ubuntu.com/ubuntu jammy InRelease Hit:2 http://azure.archive.ubuntu.com/ubuntu jammy-updates InRelease Hit:3 http://azure.archive.ubuntu.com/ubuntu jammy-backports InRelease Hit:4 http://azure.archive.ubuntu.com/ubuntu jammy-security InRelease Hit:5 https://packages.microsoft.com/ubuntu/22.04/prod jammy InRelease Hit:7 https://packages.microsoft.com/repos/azure-cli jammy InRelease Get:6 https://prod-cdn.packages.k8s.io/repositories/isv:/kubernetes:/core:/stable:/v1.30/deb InRelease [1189 B] Err:6 https://prod-cdn.packages.k8s.io/repositories/isv:/kubernetes:/core:/stable:/v1.30/deb InRelease The following signatures were invalid: EXPKEYSIG 234654DA9A296436 isv:kubernetes OBS Project Reading package lists... W: https://pkgs.k8s.io/core:/stable:/v1.30/deb/InRelease: Key is stored in legacy trusted.gpg keyring (/etc/apt/trusted.gpg), see the DEPRECATION section in apt-key(8) for details. W: GPG error: https://prod-cdn.packages.k8s.io/repositories/isv:/kubernetes:/core:/stable:/v1.30/deb InRelease: The following signatures were invalid: EXPKEYSIG 234654DA9A296436 isv:kubernetes OBS Project E: The repository 'https://pkgs.k8s.io/core:/stable:/v1.30/deb InRelease' is not signed. ```

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: don't install blobfuse v1 by default since it's deprecated
k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/blob-csi-driver/blob/master/OWNERS)~~ [andyzhangx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andyzhangx commented 2 weeks ago

/test pull-blob-csi-driver-e2e

andyzhangx commented 2 weeks ago

/retest

k8s-ci-robot commented 2 weeks ago

@andyzhangx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-blob-csi-driver-e2e-proxy 7defa64a8e7349f86542a32580517d1241564abc link true /test pull-blob-csi-driver-e2e-proxy

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).