search

kubernetes-sigs / bom

A utility to generate SPDX-compliant Bill of Materials manifests
https://kubernetes-sigs.github.io/bom/
Apache License 2.0
330 stars 48 forks source link

Fix bug breaking license downloads #241

Closed puerco closed 1 year ago

puerco commented 1 year ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes a bug that broke the license downloader. The downloader cache was being called at the wrong place and always returned null data.

It also fixes an unreported bug where download errors were being handled wrong and changes the hashing algorithm for cache entries from sha1 to sha256.

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

The main bug fix is in e85ab924cb760d7308793e4df74e03e246b74826

/cc @kubernetes-sigs/release-engineering

Does this PR introduce a user-facing change?

Fixed a bug where the license downloader was always returning nil data leading to licenses not being detected.
k8s-ci-robot commented 1 year ago

@puerco: GitHub didn't allow me to request PR reviews from the following users: kubernetes-sigs/release-engineering.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-sigs/bom/pull/241): >#### What type of PR is this? > >/kind bug > >#### What this PR does / why we need it: > >This PR fixes a bug that broke the license downloader. The downloader cache was being >called at the wrong place and always returned null data. > >It also fixes an unreported bug where download errors were being handled wrong and changes the >hashing algorithm for cache entries from sha1 to sha256. > >#### Which issue(s) this PR fixes: > >NONE > >#### Special notes for your reviewer: > >/cc @kubernetes-sigs/release-engineering > >#### Does this PR introduce a user-facing change? > >```release-note >Fixed a bug where the license downloader was always returning nil data leading to licenses not being detected. >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/bom/blob/main/OWNERS)~~ [puerco] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
puerco commented 1 year ago

Thanks @Verolop I'll sneak a fix in the next PR :hugs: