kubernetes-sigs / bom

A utility to generate SPDX-compliant Bill of Materials manifests
https://kubernetes-sigs.github.io/bom/
Apache License 2.0
337 stars 48 forks source link

Change tool string to include version #242

Closed puerco closed 1 year ago

puerco commented 1 year ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

This commit changes the tool string to add the tool version in the document Creator version. It will now pick up the tag+commit version when building a non-tagged version or "devel" when running without tags.

Which issue(s) this PR fixes:

Fixes #235 \

Special notes for your reviewer:

/cc @kubernetes-sigs/release-engineering

Does this PR introduce a user-facing change?

- Fixed a bug where the tool version was not getting included in the document creator info. The new Creator field has the app name, version tag and commit: ``bom-v0.4.1-102-g98baf66
k8s-ci-robot commented 1 year ago

@puerco: GitHub didn't allow me to request PR reviews from the following users: kubernetes-sigs/release-engineering.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-sigs/bom/pull/242): >#### What type of PR is this? > >/kind bug > > >#### What this PR does / why we need it: > >This commit changes the tool string to add the tool version in the document Creator version. It will now pick up the tag+commit version when building a non-tagged version or "devel" when running without tags. > > >#### Which issue(s) this PR fixes: > >Fixes #235 >\ >#### Special notes for your reviewer: > >/cc @kubernetes-sigs/release-engineering > >#### Does this PR introduce a user-facing change? > > >```release-note >- Fixed a bug where the tool version was not getting included in the document creator info. The new Creator field has the app name, version tag and commit: ``bom-v0.4.1-102-g98baf66 >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: puerco, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/bom/blob/main/OWNERS)~~ [puerco,saschagrunert] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment