search

kubernetes-sigs / bom

A utility to generate SPDX-compliant Bill of Materials manifests
https://kubernetes-sigs.github.io/bom/
Apache License 2.0
330 stars 48 forks source link

OSInfo: Add support for download location #270

Closed puerco closed 1 year ago

puerco commented 1 year ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds a new DownloadLocation()`` function to theosinfo.PackageDBEntry` type which can generate a download location for system packages which can be used in the SBOM. It will now be used there when it is not an empty string.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

/cc @kubernetes-sigs/release-engineering

Does this PR introduce a user-facing change?

OS Packages now can include an auto-generated download location. Initially supports Debian and Wolfi.
k8s-ci-robot commented 1 year ago

@puerco: GitHub didn't allow me to request PR reviews from the following users: kubernetes-sigs/release-engineering.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-sigs/bom/pull/270): >#### What type of PR is this? >/kind feature > > >#### What this PR does / why we need it: > >This PR adds a new `DownloadLocation()`` function to the `osinfo.PackageDBEntry` type which can generate a download location for system packages which can be used in the SBOM. It will now be used there when it is not an empty string. > > >#### Which issue(s) this PR fixes: > >None > >#### Special notes for your reviewer: > >/cc @kubernetes-sigs/release-engineering > >#### Does this PR introduce a user-facing change? > >```release-note >OS Packages now can include an auto-generated download location. Initially supports Debian and Wolfi. >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/bom/blob/main/OWNERS)~~ [cpanato,puerco] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment