kubernetes-sigs / bom

A utility to generate SPDX-compliant Bill of Materials manifests
https://kubernetes-sigs.github.io/bom/
Apache License 2.0
325 stars 48 forks source link

Fix mage verify #371

Closed pnasrat closed 9 months ago

pnasrat commented 9 months ago

Updates zeitgeist to v0.4.3 to fix version check

Tested via go run mage.go

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes local (non-ci) builds using default mage target

Which issue(s) this PR fixes:

None

See: kubernetes-sigs/zeitgeist#739 and kubernetes-sigs/release-utils#96

Special notes for your reviewer:

If you have an existing version of zeitgeist before 0.4.3 you will have to do rm $GOPATH/bin/zeitgeist before go run mage.go

Does this PR introduce a user-facing change?

NONE
k8s-ci-robot commented 9 months ago

Hi @pnasrat. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cpanato commented 9 months ago

/test all

cpanato commented 9 months ago

/ok-to-test

k8s-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, pnasrat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/bom/blob/main/OWNERS)~~ [cpanato] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment