search

kubernetes-sigs / boskos

Boskos is a resource management service that provides reservation and lifecycle management of a variety of different kinds of resources.
Apache License 2.0
123 stars 74 forks source link

Bump Go and Alpine versions #199

Closed dims closed 3 months ago

dims commented 3 months ago

Docker image fails to build, logs are here.

Step 1/18 : ARG go_version
Step 2/18 : ARG alpine_version=3.17
Step 3/18 : FROM golang:${go_version}-alpine${alpine_version} as build
manifest for golang:1.22.3-alpine3.17 not found: manifest unknown: manifest unknown
make: *** [Makefile:78: boskosctl-image] Error 1
ERROR
ERROR: build step 0 "gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20210917-12df099d55" failed: step exited with non-zero status: 2

Pick a newer image docker.io/library/golang:1.22.5-alpine3.20 instead of the missing one!

BenTheElder commented 3 months ago

do we have multiple modules here? if not let's use toolchain in go.mod and control this 100% in-repo?

dims commented 3 months ago

do we have multiple modules here? if not let's use toolchain in go.mod and control this 100% in-repo?

only one go.mod here. there's a GO_VERSION in Makefile with a validator hack/ensure-go.sh to ensure the go version is very specific .. and then the same GO_VERSION env var is used in the dockerfile/cloudbuild as well.

I don't want to do major surgery in this PR @BenTheElder

BenTheElder commented 3 months ago

/lgtm /approve

BenTheElder commented 3 months ago

there's a GO_VERSION in Makefile with a validator hack/ensure-go.sh to ensure the go version is very specific .. and then the same GO_VERSION env var is used in the dockerfile/cloudbuild as well.

toolchain should be respected in all the builds as long as we have a 1.21+ baseline

I don't want to do major surgery in this PR @BenTheElder

fair, but we should really look towards controlling go updates in the repo under test, and we should be able to do that with less effort now.

dims commented 3 months ago

/retest

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/boskos/blob/master/OWNERS)~~ [krzyzacy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment