search

kubernetes-sigs / cli-utils

This repo contains binaries that built from libraries in cli-runtime.
Apache License 2.0
156 stars 78 forks source link

fix: Add context & timeouts to e2e tests #476

Closed karlkfi closed 2 years ago

karlkfi commented 3 years ago

Tests will now each have a context that is cancelled on timeout. BeforeEach and AfterEach blocks have their own timeouts, to allow bounded setup and cleanup.

karlkfi commented 3 years ago

Blocked by https://github.com/kubernetes-sigs/cli-utils/pull/477

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cli-utils/blob/master/OWNERS)~~ [seans3] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
seans3 commented 2 years ago

/retest