kubernetes-sigs / cli-utils

This repo contains binaries that built from libraries in cli-runtime.
Apache License 2.0
156 stars 78 forks source link

Avoid waiting for failed resources #486

Closed mortent closed 2 years ago

mortent commented 2 years ago

This updates the WaitTask to handle resources that are reported as Failed. It prevents the library from waiting the full length of the wait timeout for resources that we know are unlikely to successfully reconcile.

The behavior is:

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mortent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cli-utils/blob/master/OWNERS)~~ [mortent] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mortent commented 2 years ago

@karlkfi Updated the PR with the following changes:

mortent commented 2 years ago

/retest /cc @ash2k

ash2k commented 2 years ago

I'm sorry, I will not be able to review PRs for some time.

haiyanmeng commented 2 years ago

/lgtm