Closed mortent closed 2 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mortent
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@karlkfi Updated the PR with the following changes:
WaitEvent
to use operation ReconcileFailed
rather than ReconcileStalled
. Also updated the functions and variable names accordingly.Failed
back to InProgress
. Added a test for this./retest /cc @ash2k
I'm sorry, I will not be able to review PRs for some time.
/lgtm
This updates the WaitTask to handle resources that are reported as
Failed
. It prevents the library from waiting the full length of the wait timeout for resources that we know are unlikely to successfully reconcile.The behavior is:
Failed
, the library will remove it from the set of resources we are waiting to be reconciled, add it to a set of failed resources, and send aWaitEvent
with theReconciledFailed
operation.Current
. So a resource becomingFailed
does not terminate a WaitTask, it just makes sure we don't end up waiting for the timeout to expire when we know resources are unlikely to successfully reconcile.Failed
, but happens to become unblocked before all other resources in the task has completed, it can transition out of theFailed
state. It can move either intoCurrent
orInProgress
.