fix: Handle more validation errors as field errors

karlkfi commented 2 years ago

Using field.Error allows more errors to be wrapped as a ValidationError, instead of interrupting validation and exiting early.
Add explicit validation for kind (clearer error).
Move NestedField from testutil to object, so it can be used at runtime.

karlkfi commented 2 years ago

@ash2k can you take a look at this? It's extracted from https://github.com/kubernetes-sigs/cli-utils/pull/505 which you already approved.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ash2k, karlkfi, mortent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cli-utils/blob/master/OWNERS)~~ [mortent] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubernetes-sigs / cli-utils

fix: Handle more validation errors as field errors #506