search

kubernetes-sigs / cli-utils

This repo contains binaries that built from libraries in cli-runtime.
Apache License 2.0
154 stars 77 forks source link

fix: Update ObjMetadataSet.Hash to not error #510

Closed karlkfi closed 2 years ago

karlkfi commented 2 years ago

Hash32.Write never returns an error: https://pkg.go.dev/hash#pkg-types

Hash functions should never return errors in general, because they're commonly used in String() and Equals() funcs, which don't error.

haiyanmeng commented 2 years ago

/lgtm

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi, mortent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cli-utils/blob/master/OWNERS)~~ [mortent] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment