search

kubernetes-sigs / cli-utils

This repo contains binaries that built from libraries in cli-runtime.
Apache License 2.0
155 stars 78 forks source link

capture the apply status in the inventory object #514

Closed Liujingfang1 closed 2 years ago

Liujingfang1 commented 2 years ago

Capture the apply status for individual resources after each apply. If the inventory object supports status field, it is updated after setting the inventory list at then of one apply process.

karlkfi commented 2 years ago

Please amend the commit messages to have fix or feat prefixes. I want to try to start following https://www.conventionalcommits.org/en/v1.0.0/#summary to make change logs easier to produce. If there's a breaking change, add a BREAKING CHANGE line at the end with detail.

Liujingfang1 commented 2 years ago

@mortent @karlkfi @seans3 Please take another look at the change. Let me know if there is any other concern that you have.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Liujingfang1, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cli-utils/blob/master/OWNERS)~~ [Liujingfang1,seans3] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
karlkfi commented 2 years ago

I thought this was gonna wait until I got the reconcile status in the TaskContext? I'm working on that PR now. I guess it will require an update to this...

Liujingfang1 commented 2 years ago

I think it was auto merged after the /lgtm.