search

kubernetes-sigs / cli-utils

This repo contains binaries that built from libraries in cli-runtime.
Apache License 2.0
155 stars 78 forks source link

chore: Upgrade golint, replace deprecated linters, and fix new lint errors #538

Closed karlkfi closed 2 years ago

karlkfi commented 2 years ago

This small change turned into a big project to rename a lot of the exposed API. There are no behavioral changes, but a lot of Go API changes, namely to reduce stuttering and avoid returning unexposed types from exposed functions. I've split a lot of the changes into their own commit to help make review easier.

mortent commented 2 years ago

This looks good to me. It changes a lot of names, but the majority of them are unlikely to be used by any users. And if anyone depends on them, this change will result in compile time errors, so they should be easy to find.

The commit message should probably mention the important names that are changed as a breaking change. The EventType to Type change on the events comes to mind.

I do want others to have a chance to take look too.

Liujingfang1 commented 2 years ago

I went through the change. It looks good to me.

ash2k commented 2 years ago

👍

karlkfi commented 2 years ago

Rebased and passing tests!

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cli-utils/blob/master/OWNERS)~~ [seans3] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment