Closed karlkfi closed 2 years ago
/retest
These example tests seem to be erroring over a non-error...
deployment.apps/the-deployment deleted
service/the-service deleted
configmap/the-map2 deleted
3 resource(s) deleted, 0 skipped, 0 failed to delete
Success: output line found
Success: output line found
Success: output line found
Preview strategy: server
Error: output line not found
Expected: deployment.apps/the-deployment deleted]
UPDATE: nvm. the client-side preview works, but server-side preview doesn't print any of the expected delete lines.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: karlkfi, mortent
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Found the cause of the test failure.
The DryRunStrategy was being passed in both the Options and the Builder structs. So it wasn't be propagated consistently. I've removed the one in the Builder and left it only in the Options.
/test cli-utils-presubmit-master