Critical bug in InventoryManager.SetObjectStatus means that none of the calls to SetObjectStatus actually work. Surprisingly this still passes tests, but it's likely that the status output is wrong in many cases.
The objStatus input variable is being shaddowed by the for loop.
Because of the scoping of the for loop, the bug only applies if the object status was already set. This is probably why it hasn't failed tests. But this will change is we add planned pending actuations before the aply/prune task.
Critical bug in
InventoryManager.SetObjectStatusmeans that none of the calls to SetObjectStatus actually work. Surprisingly this still passes tests, but it's likely that the status output is wrong in many cases.https://github.com/kubernetes-sigs/cli-utils/blob/master/pkg/inventory/manager.go#L68-L76
The
objStatusinput variable is being shaddowed by the for loop.Because of the scoping of the for loop, the bug only applies if the object status was already set. This is probably why it hasn't failed tests. But this will change is we add planned pending actuations before the aply/prune task.