kubernetes-sigs / cli-utils

This repo contains binaries that built from libraries in cli-runtime.
Apache License 2.0
154 stars 77 forks source link

fix: Make DependencyFilter handle DryRun #558

Closed karlkfi closed 2 years ago

karlkfi commented 2 years ago

DryRun skips WaitEvents. So the DependencyFilter needs to skip checking for reconciliation if DryRun is enabled.

Liujingfang1 commented 2 years ago

/lgtm

mortent commented 2 years ago

/approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi, mortent, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cli-utils/blob/master/OWNERS)~~ [mortent,seans3] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
karlkfi commented 2 years ago

/test cli-utils-presubmit-master

Test pod never came up... Hoping it's a flake.