Closed karlkfi closed 2 years ago
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: karlkfi, Liujingfang1
The full list of commands accepted by this bot can be found here.
The pull request process is described here
This change makes filters return an error, since all errors from apply/prune/wait are sent as events and don't terminate the task queue anyway. This exposes the reason why the object was skipped, instead of just skipping it silently.
BREAKING CHANGE: Skipped actuation events now include an error. BREAKING CHANGE: DeleteEvent.Reason replaced with an error. BREAKING CHANGE: Unused InventoryNamespaceInSet error removed. BREAKING CHANGE: InventoryOverlapError replaced with PolicyPreventedActuationError. BREAKING CHANGE: NeedAdoptionError replaced with PolicyPreventedActuationError. BREAKING CHANGE: NoInventoryObjError & MultipleInventoryObjError now use pointers.
New Error Types:
Removed error types:
Other existing error types (not used for skips):