kubernetes-sigs / cli-utils

This repo contains binaries that built from libraries in cli-runtime.
Apache License 2.0
154 stars 77 forks source link

feat: expose skip reason as error #562

Closed karlkfi closed 2 years ago

karlkfi commented 2 years ago

This change makes filters return an error, since all errors from apply/prune/wait are sent as events and don't terminate the task queue anyway. This exposes the reason why the object was skipped, instead of just skipping it silently.

BREAKING CHANGE: Skipped actuation events now include an error. BREAKING CHANGE: DeleteEvent.Reason replaced with an error. BREAKING CHANGE: Unused InventoryNamespaceInSet error removed. BREAKING CHANGE: InventoryOverlapError replaced with PolicyPreventedActuationError. BREAKING CHANGE: NeedAdoptionError replaced with PolicyPreventedActuationError. BREAKING CHANGE: NoInventoryObjError & MultipleInventoryObjError now use pointers.

New Error Types:

Removed error types:

Other existing error types (not used for skips):

Liujingfang1 commented 2 years ago

/lgtm /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi, Liujingfang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cli-utils/blob/master/OWNERS)~~ [Liujingfang1] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment