Bug: event printer only prints reconcile summary once (should be 1 for apply wait & 1 for prune wait)

kubernetes-sigs / cli-utils

This repo contains binaries that built from libraries in cli-runtime.

Apache License 2.0

154 stars 77 forks source link

Bug: event printer only prints reconcile summary once (should be 1 for apply wait & 1 for prune wait) #569

Closed karlkfi closed 2 years ago

karlkfi commented 2 years ago

Example output:

configmap/cm-c apply skipped: dependency scheduled for delete: _test-namespace__Namespace
1 resource(s) applied. 0 created, 1 unchanged, 0 configured, 0 failed
configmap/cm-c reconcile skipped
configmap/cm-a pruned
configmap/cm-a reconcile pending
configmap/cm-a reconciled
configmap/cm-b pruned
namespace/test-namespace prune skipped: namespace still in use: test-namespace
2 resource(s) pruned, 1 skipped, 0 failed to prune
configmap/cm-b reconcile pending
namespace/test-namespace reconcile skipped
configmap/cm-b reconciled
2 resource(s) reconciled, 2 skipped, 0 failed to reconcile, 0 timed out

You can see there's both apply and prune, and the apply & prune groups each get their own summary print, but the reconcile print only happens at the end of the prune wait, not at the end of the apply wait.

Also, we probably need a total summary, not just action group summaries.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

karlkfi commented 2 years ago

I think the summary output was changed recently to be more clear.