Closed karlkfi closed 2 years ago
I expect example tests to fail here, because I haven't updated them with the new event printer changes yet.
Overall the change looks good to me.
+1 one on the new printer output that includes the total number.
expectedOutputLine "reconcile result: 2 attempted, 2 successful, 0 skipped, 0 failed, 0 timed out"
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: karlkfi, mortent
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Rebased. Tests passed. Needs another LGTM.
/lgtm
Event Changes
* Timeout is only currently possible for Wait events, but we may add it to other events status in the future. For now, those events and API calls do not have a client-side timeout.
** Action groups will continue to use "Started" & "Finished" as their status enum values, because action groups have no success or failure mode, so renaming them Pending and Successful would be misleading, but if we ever decide to add an error, then renaming them might make sense for consistency.
Printer Changes
All Printers
Event Printer
JSON Printer
Table Printer
BREAKING CHANGES