search

kubernetes-sigs / cli-utils

This repo contains binaries that built from libraries in cli-runtime.
Apache License 2.0
155 stars 78 forks source link

chore: update k8s libs to 1.24 #577

Closed mengqiy closed 2 years ago

mengqiy commented 2 years ago

We want to bump the k8s dependencies, since when want to import a newer kyaml version in kpt. This kyaml version is only compatible with k8s v0.24+ due import path change in https://github.com/kubernetes/kube-openapi/pull/285.

mengqiy commented 2 years ago

/retest

mengqiy commented 2 years ago

/cc @mortent

mengqiy commented 2 years ago

/cc @karlkfi

yuwenma commented 2 years ago

This PR will fix the go mod conflicts we had in kpt and porch, and it is critical for all the users who use both KRM functions (new sdk) and cli-utils!

karlkfi commented 2 years ago

Historically we haven't taken new k8s versions until they're fully released and can be picked up by the known downstream clients (kpt, Config Sync, GitLab Agent). I'm not sure how to handle a release candidate. My best advice would be to temporarily vendor cli-utils with your changes into your downstream client, until cli-util is updated with the change and a new release is cut.

mengqiy commented 2 years ago

Rebased. PTAL

karlkfi commented 2 years ago

/hold

Blocking until https://github.com/kubernetes-sigs/cli-utils/pull/572 is merged.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi, mengqiy, mortent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cli-utils/blob/master/OWNERS)~~ [mortent] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
karlkfi commented 2 years ago

/unhold