Closed karlkfi closed 2 years ago
- If
GOPATH
contains a path with a space, it will be used to split the path into pieces where it's not double quoted, right? I think the right thing to do would be to quote all$(MOGOBIN)
and$(GOPATH)
references.GOPATH
is a list of paths, not a single path. This is annoying. I'm not asking to fix how things work with it as it's very rare in practice, just FYI :)
Oh man... it's worse than I expected...
The GOPATH environment variable lists places to look for Go code. On Unix, the value is a colon-separated string. On Windows, the value is a semicolon-separated string. On Plan 9, the value is a list.
I'm not gonna parse that. If you want to use something specific, you can specify the GOPATH or MYGOBIN make var values.
I did change it to quote the value tho, so it will cause a path not found error if it's a list.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ash2k, karlkfi, mortent
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Looks like a flaky test. Fix: https://github.com/kubernetes-sigs/cli-utils/pull/581