search

kubernetes-sigs / cli-utils

This repo contains binaries that built from libraries in cli-runtime.
Apache License 2.0
155 stars 78 forks source link

chore: Upgrade to Ginkgo v2 #583

Closed karlkfi closed 2 years ago

karlkfi commented 2 years ago

Lots of goodies in the new version, and v1 is deprecated, but mostly I want access to be able to run the memory profiler. https://onsi.github.io/ginkgo/MIGRATING_TO_V2 https://github.com/onsi/ginkgo/issues/766

Had to refactor the tests a bit because the new version doesn't allow BeforeSuite/AfterSuite inside another Context/Describe container.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi, mortent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cli-utils/blob/master/OWNERS)~~ [mortent] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment