fix: make deletion idempotent

karlkfi commented 2 years ago

Don't error when a delete returns NotFound. This means the object was deleted asynchronously by another client between the initial GET for task scheduling and the delete task itself. Log a warning, because it's possible the deletion may have violated dependency ordering.
Update apply and delete task logs to only log errors if the verbosity is greater than -v=4. This should help reduce duplicate log messages.

karlkfi commented 2 years ago

/test cli-utils-presubmit-master-stress

Liujingfang1 commented 2 years ago

/lgtm /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi, Liujingfang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cli-utils/blob/master/OWNERS)~~ [Liujingfang1] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubernetes-sigs / cli-utils

fix: make deletion idempotent #588