Closed chunglu-chou closed 2 years ago
Hi @chunglu-chou. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
Code looks good. Could we add a test for this functionality?
@mortent Yes, I think I could reuse the test cases in the current one and just make it output as json format to verify the result.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chunglu-chou, mortent
The full list of commands accepted by this bot can be found here.
The pull request process is described here
This change is to make the status command work for other inventory types. Add json printer to support json output format including a new field named inventory-name. Add testing data for json output format.