Closed manfredlift closed 1 year ago
Hi @manfredlift. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
/ok-to-test
/retest
/retest
/retest
/retest
/retest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: karlkfi, manfredlift, seans3
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Fixes https://github.com/kubernetes-sigs/cli-utils/issues/613
Description
During pruning the code is filtering objects with
CurrentUIDFilter
:This must mean that the object has ended up being tracked in the inventory by more than one reference and the one that was flagged by the filter should be removed from the inventory. Otherwise, it gets stuck in the inventory indefinitely and during every invocation of prune it'll be logged as skipped.
A good example of this is
Ingress
kind existing in both groupsextensions
andnetworking.k8s.io
in k8s 1.19 & 1.20. This means when you rename the apiGroup in your local yaml to the new recommended group, then the reference with the old group name gets permastuck in the inventory.