fix: retain inventory for pruning fail/skip

[sdowell]

Prior to this change, the inventory always was deleted at the end of a Destroy event. This would occur even in the case of a pruning skip/failure, resulting in the objects being removed from the inventory without being deleted. This change makes it so that the inventory is only deleted if all objects have been deleted and reconciled.

[k8s-ci-robot]

Welcome @sdowell!

It looks like this is your first PR to kubernetes-sigs/cli-utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cli-utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @sdowell. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[sdowell]

/assign @karlkfi

[sdowell]

@karlkfi Added an e2e test and updated the logic to not consider delete/reconcile skips. I also added timeoutReconciles as a condition to consider a failure

[karlkfi]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi, sdowell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cli-utils/blob/master/OWNERS)~~ [karlkfi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[sdowell]

/retest

[sdowell]

Job execution failed: Pod got deleted unexpectedly /retest

[karlkfi]

/retest

[sdowell]

/retest

[sdowell]

/retest

[sdowell]

/retest

[sdowell]

/retest

[sdowell]

/retest

[sdowell]

/retest

[sdowell]

/test cli-utils-presubmit-master-stress

[karlkfi]

/retest

[sdowell]

/test cli-utils-presubmit-master-stress

[sdowell]

/test cli-utils-presubmit-master-stress

[sdowell]

/test cli-utils-presubmit-master-stress

[karlkfi]

/lgtm