search

kubernetes-sigs / cli-utils

This repo contains binaries that built from libraries in cli-runtime.
Apache License 2.0
155 stars 77 forks source link

fix: retain objects which failed to reconcile #623

Closed sdowell closed 1 year ago

sdowell commented 1 year ago

This change updates the set-inventory logic to retain objects which failed to reconcile. This ensures that if you run the applier/destroyer multiple times, an object that is failing to reconcile will be retained in the inventory. Before this change, an object failing to reconcile could be lost after multiple attempts (e.g. multiple destroys).

k8s-ci-robot commented 1 year ago

Hi @sdowell. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sdowell commented 1 year ago

This change is based on https://github.com/kubernetes-sigs/cli-utils/pull/622

sdowell commented 1 year ago

/assign @karlkfi

mortent commented 1 year ago

/ok-to-test

sdowell commented 1 year ago

/retest

sdowell commented 1 year ago

/test cli-utils-presubmit-master-stress

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi, sdowell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cli-utils/blob/master/OWNERS)~~ [karlkfi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment