search

kubernetes-sigs / cli-utils

This repo contains binaries that built from libraries in cli-runtime.
Apache License 2.0
155 stars 77 forks source link

Update gnostic dependency with gnostic-models #625

Closed liangyuanpeng closed 7 months ago

liangyuanpeng commented 1 year ago

Related:

This PR changed:

k8s-ci-robot commented 1 year ago

Welcome @liangyuanpeng!

It looks like this is your first PR to kubernetes-sigs/cli-utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cli-utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 year ago

Hi @liangyuanpeng. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
liangyuanpeng commented 1 year ago

cc @seans3 @Liujingfang1 @mortent @karlkfi

stefanprodan commented 9 months ago

@liangyuanpeng could you please revive this PR. We really need this merged to unblock the Flux upgrade to Kubernetes 1.28. Thank you!

ash2k commented 9 months ago

/ok-to-test

ash2k commented 9 months ago

/lgtm

@seans3 PTAL.

liangyuanpeng commented 8 months ago

@ash2k @seans3 Update to v0.28.4 and not v0.28.0, PTAL,Thanks!

ash2k commented 8 months ago

/lgtm

liangyuanpeng commented 8 months ago

@stefanprodan Thanks for remind. You are the end user and have already applied this change to fluxcd, so I followed your advice and updated. Since the CI is green without this change, it would be great if you could provide more information to increase the reviewer's confidence.

Sorry about duplicate lgtm.

ash2k commented 8 months ago

/lgtm

ash2k commented 8 months ago

@seans3 @karlkfi I think this is ready for merging, PTAL.

mortent commented 7 months ago

/approve

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangyuanpeng, mortent, stefanprodan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cli-utils/blob/master/OWNERS)~~ [mortent] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
liangyuanpeng commented 7 months ago

Thanks @mortent for approve and thanks @ash2k help to push it.