search

kubernetes-sigs / cli-utils

This repo contains binaries that built from libraries in cli-runtime.
Apache License 2.0
155 stars 77 forks source link

Bump golangci-lint #628

Closed ash2k closed 1 year ago

ash2k commented 1 year ago

Maybe this will resolve the linter being killed in https://github.com/kubernetes-sigs/cli-utils/pull/619? I have no idea why it's getting killed.

seans3 commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ash2k, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cli-utils/blob/master/OWNERS)~~ [seans3] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
seans3 commented 1 year ago

/hold

Reconcile with this? https://github.com/kubernetes-sigs/cli-utils/pull/627

k8s-ci-robot commented 1 year ago

@ash2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
cli-utils-presubmit-master 40542348c83b0ed9ac07b44549414842471622bc link true /test cli-utils-presubmit-master
cli-utils-presubmit-master-stress 40542348c83b0ed9ac07b44549414842471622bc link true /test cli-utils-presubmit-master-stress

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ash2k commented 1 year ago

Opened https://github.com/kubernetes-sigs/cli-utils/pull/629.