search

kubernetes-sigs / cloud-provider-azure

Cloud provider for Azure
https://cloud-provider-azure.sigs.k8s.io/
Apache License 2.0
266 stars 274 forks source link

Migrate to Microsoft Authentication Library (MSAL) #430

Open feiskyer opened 3 years ago

feiskyer commented 3 years ago

per the AAD docs here, we should migrate ADAL to MSAL:

Q: Is ADAL being deprecated? A: Yes. Starting June 30th, 2020, we will no longer add new features to ADAL. We'll continue adding critical security fixes to ADAL until June 30th, 2022. After this date, your apps using ADAL will continue to work, but we recommend upgrading to MSAL to take advantage of the latest features and to stay secure.

Dependency

The GO library AzureAD/microsoft-authentication-library-for-go is not yet ready for public preview.

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

pierluigilenoci commented 3 years ago

/remove-lifecycle stale

k8s-triage-robot commented 3 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pierluigilenoci commented 2 years ago

@feiskyer so what happens to this issue?

MartinForReal commented 2 years ago

related: https://github.com/Azure/azure-sdk-for-go/issues/14920

feiskyer commented 2 years ago

https://github.com/AzureAD/microsoft-authentication-library-for-go is not ready yet for production, it is still in preview version.

patrickdillon commented 2 years ago

The azidentity package is stable: https://azure.github.io/azure-sdk/releases/latest/index.html#go. ADAL deprecation is the end of this month. It looks like everything is set for migration and it should be a priority. Are there still blockers?

MartinForReal commented 2 years ago

multi-tenant support is not merged. https://github.com/Azure/azure-sdk-for-go/issues/17159

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

MartinForReal commented 1 year ago

https://github.com/Azure/azure-sdk-for-go/issues/17159#issuecomment-1421238790

feature is in preview.

MartinForReal commented 1 year ago

/remove-lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

sdodson commented 1 year ago

Seems unblocked now that v1.3.0 went GA back in May? https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azidentity/CHANGELOG.md#130-2023-05-09

MartinForReal commented 1 year ago

support is added in track2 sdk client. will close this issue once the new client is adopted. https://pkg.go.dev/sigs.k8s.io/cloud-provider-azure/pkg/azclient

pierluigilenoci commented 1 year ago

/remove-lifecycle stale

feiskyer commented 1 year ago

/assign @MartinForReal

feiskyer commented 1 year ago

This would be done together with Azure track2 SDK migration.

k8s-triage-robot commented 10 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pierluigilenoci commented 10 months ago

@feiskyer what about Azure track2 SDK migration?

MartinForReal commented 10 months ago

@pierluigilenoci The clients are generated. And azure csi drivers have been migrated to these clients.

MartinForReal commented 10 months ago

/remove-lifecycle stale

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pierluigilenoci commented 7 months ago

/remove-lifecycle stale

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pierluigilenoci commented 1 month ago

/remove-lifecycle stale

pierluigilenoci commented 1 month ago

@feiskyer Is there any chance of seeing it made?