kubernetes-sigs / cloud-provider-azure

Cloud provider for Azure
https://cloud-provider-azure.sigs.k8s.io/
Apache License 2.0
260 stars 273 forks source link

Duplicate annotation "service.beta.kubernetes.io/azure-disable-load-b… #6332

Closed braieralves closed 4 months ago

braieralves commented 4 months ago

…alancer-floating-ip".md

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Fix the duplicated information in this annotation "service.beta.kubernetes.io/service.beta.kubernetes.io/azure-disable-load-balancer-floating-ip"

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented 4 months ago

Hi @braieralves. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 4 months ago

Deploy Preview for kubernetes-sigs-cloud-provide-azure ready!

Name Link
Latest commit 402d95b4349c97ab328daad4dbc18607d9a1ced0
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/665f35094ee77200076bc8e8
Deploy Preview https://deploy-preview-6332--kubernetes-sigs-cloud-provide-azure.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

MartinForReal commented 4 months ago

/ok-to-test

MartinForReal commented 4 months ago

/lgtm /approve

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: braieralves, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cloud-provider-azure/blob/documentation/OWNERS)~~ [MartinForReal] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
MartinForReal commented 4 months ago

/release-note-none

MartinForReal commented 4 months ago

@braieralves Thanks for the update!