kubernetes-sigs / cloud-provider-azure

Cloud provider for Azure
https://cloud-provider-azure.sigs.k8s.io/
Apache License 2.0
260 stars 274 forks source link

Refactor fetching retain ports when reconciling SecurityGroup #6401

Closed zarvd closed 3 months ago

zarvd commented 3 months ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #6151

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix updating NSG rules when disabling floating IP 

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented 3 months ago

Hi @zarvd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
nilo19 commented 3 months ago

/ok-to-test

nilo19 commented 3 months ago

Do you consider internal/testutil -> testutil/?

zarvd commented 3 months ago

Do you consider internal/testutil -> testutil/?

I am thinking not to export this pkg, and maybe some more

nilo19 commented 3 months ago

Do you consider internal/testutil -> testutil/?

I am thinking not to export this pkg, and maybe some more

Then I think we should include this change within the pr.

nilo19 commented 3 months ago

/lgtm

zarvd commented 3 months ago

/retest

MartinForReal commented 3 months ago

/approve

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MartinForReal, zarvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cloud-provider-azure/blob/master/OWNERS)~~ [MartinForReal] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
MartinForReal commented 3 months ago

/lgtm

coveralls commented 3 months ago

Coverage Status

Changes unknown when pulling 4f1f24a7161acbce60cdb22f656a27d1a54e8a01 on zarvd:refactor/tidy-access-control into on kubernetes-sigs:master.

zarvd commented 3 months ago

/kind bug