Closed zarvd closed 3 months ago
Hi @zarvd. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
Do you consider internal/testutil -> testutil/?
Do you consider internal/testutil -> testutil/?
I am thinking not to export this pkg, and maybe some more
Do you consider internal/testutil -> testutil/?
I am thinking not to export this pkg, and maybe some more
Then I think we should include this change within the pr.
/lgtm
/retest
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: MartinForReal, zarvd
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
/kind bug
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #6151
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: