search

kubernetes-sigs / cloud-provider-azure

Cloud provider for Azure
https://cloud-provider-azure.sigs.k8s.io/
Apache License 2.0
258 stars 271 forks source link

Migrate test-infra jobs to community clusters #6577

Closed nilo19 closed 3 weeks ago

nilo19 commented 1 month ago

What would you like to be added:

Migrate test-infra jobs to community clusters

Why is this needed:

nilo19 commented 1 month ago

waiting for https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/4976

dtzar commented 1 month ago

@nilo19 do not wait for all of our tests to finish here. You should be able to get started now to make the August 1st deadline.

I created a separate report here for all the tests which need to be migrated that I can update periodically for status.

dtzar commented 1 month ago

https://github.com/kubernetes/test-infra/pull/33048 is related to this issue

nojnhuh commented 1 month ago

This issue will likely also require updating any templates here used with CAPZ 1.16 to use an AzureClusterIdentity with WorkloadIdentity: https://github.com/kubernetes-sigs/cloud-provider-azure/tree/master/tests/k8s-azure/manifest/cluster-api. The one we use in our test for ci-entrypoint looks like this:

apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: AzureClusterIdentity
metadata:
  labels:
    clusterctl.cluster.x-k8s.io/move-hierarchy: "true"
  name: ${CLUSTER_IDENTITY_NAME}
  namespace: default
spec:
  allowedNamespaces: {}
  clientID: ${AZURE_CLIENT_ID_USER_ASSIGNED_IDENTITY}
  tenantID: ${AZURE_TENANT_ID}
  type: WorkloadIdentity
nawazkh commented 1 month ago

Adding CAPZ issue as a node into this graph of test-migration changes for booking purposes. https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/4976

My bad, it's been added up there already. Closing this comment.