search

kubernetes-sigs / cloud-provider-azure

Cloud provider for Azure
https://cloud-provider-azure.sigs.k8s.io/
Apache License 2.0
260 stars 274 forks source link

Track2 sdk:migrate nsg client to track2 one #7155

Closed MartinForReal closed 1 day ago

MartinForReal commented 2 days ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Track2 sdk:migrate nsg client to track2 one

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The apiVersion of network security group is bumped to 2024-01-01
The apiVersion of VirtualNetworkLink is bumpted to 2020-06-01
The apiVersion of PrivateZone is bumpted to 2020-06-01

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

coveralls commented 2 days ago

Coverage Status

coverage: 76.737% (-0.1%) from 76.885% when pulling 32cc96695278e17f50b7b04100f80715416cb8d9 on MartinForReal:shafan/sg into ffcf976143d4916798d9cf7870c3b0950da18bf6 on kubernetes-sigs:master.

k8s-ci-robot commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, MartinForReal, zarvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cloud-provider-azure/blob/master/OWNERS)~~ [MartinForReal,feiskyer] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
feiskyer commented 2 days ago

/lgtm