kubernetes-sigs / cloud-provider-equinix-metal

Kubernetes Cloud Provider for Equinix Metal (formerly Packet Cloud Controller Manager)
https://deploy.equinix.com/labs/cloud-provider-equinix-metal
Apache License 2.0
74 stars 27 forks source link

EMLB service load balancing conflicts with EIP control plane load balancing #476

Open ctreatma opened 10 months ago

ctreatma commented 10 months ago

Version 3.7.0 introduced support for external load balancers with Equinix Metal Load Balancers (EMLB). Prior to this change, the EIP-based control plane load balancer was explicitly ignored by the load balancer controller by checking the service namespace & name. When EMLB load balancing is enabled, we bypassed that service namespace & name check so that the load balancer controller could manage the control plane load balancer.

However, since both the EIP- and EMLB-based control plane load balancers create k8s service objects, if a customer who is currently using EIP-based control plane load balancing attempts to enable EMLB load balancing for their services, the load balancer controller will see the service object for the EIP-based control plane load balancer and create an EMLB load balancer for it, even though the customer did not specify a loadBalancerID in order to explicitly enable EMLB-based control plane load balancing.

We should update CPEM so that if the customer is using EIP-based control plane load balancing, the load balancer controller ignores the service object regardless of the currently-selected load balancer implementation. It's possible we could do this by updating the control plane EIP reconciler to add a load balancer class to the service object it creates. When a load balancer class is present, kubernetes hides the service from the cloud provider; since we're using an informer to manage the EIP-based service object, I think that enables us to continue to manage the EIP directly even though our load balancer controller can't see it.

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 5 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/cloud-provider-equinix-metal/issues/476#issuecomment-2028809522): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cprivitere commented 3 months ago

/reopen

k8s-ci-robot commented 3 months ago

@cprivitere: Reopened this issue.

In response to [this](https://github.com/kubernetes-sigs/cloud-provider-equinix-metal/issues/476#issuecomment-2110609453): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
cprivitere commented 3 months ago

/remove-lifecycle rotten

cprivitere commented 3 months ago

/triage accepted