search

kubernetes-sigs / cloud-provider-equinix-metal

Kubernetes Cloud Provider for Equinix Metal (formerly Packet Cloud Controller Manager)
https://deploy.equinix.com/labs/cloud-provider-equinix-metal
Apache License 2.0
73 stars 26 forks source link

fix: enable equinix-sdk-go debugging when PACKNGO_DEBUG env var is set #551

Closed ctreatma closed 1 month ago

ctreatma commented 1 month ago

The old packngo SDK had built-in support for enabling debug logging if the PACKNGO_DEBUG environment variable was set to any value. The generated equinix-sdk-go SDK requires explicitly enabling debug logging in consumer code, so when we switched from packngo to equinix-sdk-go we lost support for the PACKNGO_DEBUG environment variable. This updates CPEM to enable debug logging for equinix-sdk-go if the old PACKNGO_DEBUG environment variable is set.

Fixes #517

cprivitere commented 1 month ago

/approve

cprivitere commented 1 month ago

/lgtm

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cprivitere, ctreatma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cloud-provider-equinix-metal/blob/main/OWNERS)~~ [cprivitere] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment