kubernetes-sigs / cloud-provider-kind

Cloud provider for KIND clusters
Apache License 2.0
139 stars 34 forks source link

Fails to detect `nerdctl` instead of `docker` #130

Open kriswuollett opened 5 days ago

kriswuollett commented 5 days ago

Expected docker alternatives to be detected in the same way as in kind. Getting error exec: "docker": executable file not found in $PATH:

E0912 21:00:08.842881  117699 controller.go:298] error processing service projectcontour/envoy (retrying with exponential backoff): failed to ensure load balancer: failed to create continers kindccm-GZ4YR5X5RDVG26ZXXYAU2GKKAVOAEUPJFJGPZD72 [--detach --tty --label io.x-k8s.cloud-provider-kind.cluster=nyc3-shared --label io.x-k8s.cloud-provider-kind.loadbalancer.name=nyc3-shared/projectcontour/envoy --net kind --init=false --hostname kindccm-GZ4YR5X5RDVG26ZXXYAU2GKKAVOAEUPJFJGPZD72 --privileged --restart=on-failure --sysctl=net.ipv4.ip_forward=1 --sysctl=net.ipv6.conf.all.disable_ipv6=0 --sysctl=net.ipv6.conf.all.forwarding=1 --sysctl=net.ipv4.conf.all.rp_filter=0 --publish=10000/TCP --publish-all envoyproxy/envoy:v1.30.1 bash -c echo -en 'node:
  cluster: cloud-provider-kind
  id: cloud-provider-kind-id

dynamic_resources:
  cds_config:
    resource_api_version: V3
    path: /home/envoy/cds.yaml
  lds_config:
    resource_api_version: V3
    path: /home/envoy/lds.yaml

admin:
  access_log_path: /dev/stdout
  address:
    socket_address:
      address: 0.0.0.0
      port_value: 10000
' > /home/envoy/envoy.yaml && touch /home/envoy/cds.yaml && touch /home/envoy/lds.yaml && while true; do envoy -c /home/envoy/envoy.yaml && break; sleep 1; done]: exec: "docker": executable file not found in $PATH
aojea commented 5 days ago

Yeah, is is missing, good catch ... PRs are welcome https://github.com/kubernetes-sigs/cloud-provider-kind/blob/7d92b656f0b1a878c86e61ca3be31a69ddcd1b96/pkg/container/container.go#L15-L45

cc @estesp